This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
fix: prevent bn254 feature flag always being enabled
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
bls13_381 field flagsbn254 feature flag always being enabled
kevaundray
reviewed
Apr 24, 2023
kevaundray
reviewed
Apr 24, 2023
kevaundray
reviewed
Apr 24, 2023
kevaundray
approved these changes
Apr 26, 2023
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)
Resolves (link to issue)
Description
Summary of changes
Currently we're always turning on the
bn254field due to default feature flags, this makes it impossible to use any different fields. I've fixed the feature flag setup so that only the field supplied to theacvmpackage gets turned on.The second commit contains some miscellaneous cleanup of the various toml files.
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmtwith default settings.Additional context
(If applicable.)